Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic component placeholders #7447

Draft
wants to merge 2 commits into
base: antoine/codegen-no-default
Choose a base branch
from

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Sep 19, 2024

What

Introduces generic placeholders, allowing to..

  • leave out Default implementations in many cases
  • fearless request a placeholder because it's guarnated to be available

Wrinkles:

  • component name must be registered. If that's not the case we're kinda lost, just like in other places in the code. The workaround here is that you get the placeholder for Null datatype
  • a bit excessive on the allocation side, some caching might be nice, then we could return references to arrow data instead of giving out boxes again. Unlikely to be an actual perf concern afaik

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

jprochazk and others added 2 commits September 18, 2024 18:21
### What

We removed large binary files from the `rerun-io/mp4` repository,
planning to move those over to git LFS. But that means that all the
commit hashes changed, including the one we're on.

This updates to
rerun-io/mp4@b019fcf
which is NOT the latest commit on `rerun-io/mp4` - this is intentional,
the latest commit contains breaking changes that we'll update to later.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7441?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7441?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/7441)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
@Wumpf Wumpf changed the title Andreas/automatic component placeholders Generic component placeholders Sep 19, 2024
@Wumpf Wumpf added the 🚜 refactor Change the code, not the functionality label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants