-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use slimmer docker image #10
use slimmer docker image #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! This looks great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, i can see that the linker script for musl compilation is no longer present. is this deliberate? does this still work for musl builds?
after reorganising the dockerfile I wanted to see if it would work without linking the licstdc++, but there is no pipeline here to verify, so I restored it |
nice! I'll merge and check if a binary build still works over in the main repo |
haha, thats actually because we updated the docker.yml over in the main repo to use a much beefier actions runner |
OK, i had to add build-essential but otherwise seems to work. thanks again |
improvements:
Layer Reduction: Combined RUN commands where appropriate.
Smaller Base Image: Used bookworm-slim as the base to reduce image size.
Removed Unnecessary Packages: Used --no-install-recommends to install only necessary packages, avoiding bloated images.
might help a little bit in resolving #7