Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use slimmer docker image #10

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

aradwann
Copy link
Contributor

@aradwann aradwann commented Sep 6, 2024

improvements:
Layer Reduction: Combined RUN commands where appropriate.
Smaller Base Image: Used bookworm-slim as the base to reduce image size.
Removed Unnecessary Packages: Used --no-install-recommends to install only necessary packages, avoiding bloated images.

might help a little bit in resolving #7

Copy link
Contributor

@jackkleeman jackkleeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! This looks great

Copy link
Contributor

@jackkleeman jackkleeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, i can see that the linker script for musl compilation is no longer present. is this deliberate? does this still work for musl builds?

@aradwann
Copy link
Contributor Author

actually, i can see that the linker script for musl compilation is no longer present. is this deliberate? does this still work for musl builds?

after reorganising the dockerfile I wanted to see if it would work without linking the licstdc++, but there is no pipeline here to verify, so I restored it

@jackkleeman
Copy link
Contributor

nice! I'll merge and check if a binary build still works over in the main repo

@jackkleeman jackkleeman merged commit 472866c into restatedev:main Oct 15, 2024
@aradwann
Copy link
Contributor Author

GH in this repo

before
image

after
Screenshot from 2024-10-15 12-31-05

that's a good sign!

@jackkleeman
Copy link
Contributor

haha, thats actually because we updated the docker.yml over in the main repo to use a much beefier actions runner

@jackkleeman
Copy link
Contributor

OK, i had to add build-essential but otherwise seems to work. thanks again

@aradwann aradwann deleted the use-slimmer-docker-image branch October 15, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants