Introduces NetworkServerBuilder to enable inversion of grpc service registration #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egistration This allows roles/services to add services to node-rpc-server on startup with no requirement for Node to know about service construction requirements. Part of this PR temporarily removes QueryStorage API from NodeSvc as it should not belong here. This should either move to its own gRPC service (thanks to the new registration mechanic) or to be removed completely if this is to be replaced by node-to-node networking.
|
This looks like a very neat change directionally! |
tillrohrmann
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Great work @AhmedSoliman. The changes look good to me. This PR will be merged as part of #2182.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows roles/services to add services to node-rpc-server on startup with no requirement for Node to know about service construction requirements.
Part of this PR temporarily removes QueryStorage API from NodeSvc as it should not belong here. This should either move to its own gRPC service (thanks to the new registration mechanic) or to be removed completely if this is to be replaced by node-to-node networking.
Stack created with Sapling. Best reviewed with ReviewStack.