Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run embedded metadata store on node grpc server #2185

Merged

Conversation

tillrohrmann
Copy link
Contributor

By letting the embedded metadata store run on the node grpc server
we can get rid of an additional address that users need to configure.
Instead of being reachable under port 5123, the metadata store is now
reachable under port 5122 by default.

This PR is based on #2182.

As a follow-up we need to update our materials to no longer mention the metadata store port.

@aradwann
Copy link
Contributor

this will partially resolve #1609 ?

Copy link
Contributor

@muhamadazmy muhamadazmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tillrohrmann for creating this PR. It looks good to me (and makes sense) the only part I have questions over is the Replace QueryStorage grpc with QueryContext commit! I don't see how this relate to embedding medatadata store on node grpc service and feels out of place (as far as I can see) I must be missing some context regarding to this single commit.

So my question is why this commit is needed and how is it related to the rest of the PR.

@tillrohrmann
Copy link
Contributor Author

tillrohrmann commented Nov 4, 2024

I needed e40eee1 which needs Replace QueryStorage grpc with QueryContext to be complete. That's why this PR is based on these two commits. For this change, the QueryStorage change is semantically not needed.

@tillrohrmann tillrohrmann force-pushed the metadata-store-uses-node-server branch from 15dfa5a to 67a7bf2 Compare November 4, 2024 09:29
@tillrohrmann
Copy link
Contributor Author

Thanks for your review @muhamadazmy. I've rebased the PR onto the latest main. Hopefully, I could answer your question regarding the previous commits.

@tillrohrmann
Copy link
Contributor Author

Thanks for the reviews @muhamadazmy and @slinkydeveloper. Merging this PR now.

By letting the embedded metadata store run on the node grpc server
we can get rid of an additional address that users need to configure.
Instead of being reachable under port 5123, the metadata store is now
reachable under port 5122 by default.
@tillrohrmann tillrohrmann force-pushed the metadata-store-uses-node-server branch from 67a7bf2 to c1f742a Compare November 4, 2024 16:42
@tillrohrmann tillrohrmann merged commit c1f742a into restatedev:main Nov 4, 2024
12 checks passed
@tillrohrmann tillrohrmann deleted the metadata-store-uses-node-server branch November 4, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants