Introduce retry-policy to shuffle #2228
Open
+49
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 7, 2024
muhamadazmy
force-pushed
the
pr2228
branch
2 times, most recently
from
94ee2a2
to
2d01133
Compare
| /// # Append retry policy | ||
| /// | ||
| /// Retry policy for appending records to virtual log (bifrost) | ||
| pub append_retry_policy: RetryPolicy, |
There was a problem hiding this comment.
any reason why we shouldn't use bifrost's append_retry_policy?
There was a problem hiding this comment.
I honestly wasn't sure if the bifrost append retry policy should be reused here. In my mind the two polices are not related since one of them is internal to bifrost operation, while this one is from a perspective of a bifrost user (the shuffler in this case)
That being said, I am totally fine to drop this one and reuse the one from bifrost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce retry-policy to shuffle
Fixes #2148