Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Attach/Get output in service-protocol #2266

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Implement Attach/Get output in service-protocol #2266

wants to merge 5 commits into from
+912 −64

Conversation

slinkydeveloper
Copy link
Contributor

Part of #1708

@slinkydeveloper
WIP remove this and replace with git subtree update
e7830d2
@slinkydeveloper
Add parsing of AttachInvocationEntryMessage and GetInvocationOutputEn…
a6410f5 
…tryMessage
@slinkydeveloper
Add new field to AttachInvocation to reply immediately when the invoc…
2ffcc22 
…ation is in-flight (essentially implementing the get invocation output semantics we already have for the ingress), handle it and test it.

This commit also contains a "special case" for get invocation output, that translates the CompletionResult with NOT_READY_ERROR into Empty. This was done to have a good API for the service-protocol, but for the time being I don't want to change the `InvocationResponse` command in the WAL protocol. We might reconsider this anyway when we'll get to the immutable log.
@slinkydeveloper
Add OutboxMessage::AttachInvocation to propose Command::AttachInvocat…
8c115c8 
…ion in another PP
@slinkydeveloper
Implement the new entry messages
02ad47a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalshilman igalshilman igalshilman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slinkydeveloper @igalshilman