Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Might be a compiler bug or some stuff like that 🤷 #2287

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Might be a compiler bug or some stuff like that 🤷 #2287

wants to merge 1 commit into from
+49 −38

Conversation

slinkydeveloper
Copy link
Contributor

No description provided.

@AhmedSoliman
Copy link
Contributor

I don't understand. What is the bug or the issue this PR solves?

@slinkydeveloper
Copy link
Contributor Author

The PR name was temporary, I was still testing this out, but it's a funny one :D

So there is an issue with the usage of debug_if_leader! macro within the match, just look at the diff. Without this PR, those log lines will never be printed, as if that code would have never existed. With my fix, those log lines get printed (when debug logging is enabled ofc).

I'm still trying to wrap my head around why this happens though :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann Awaiting requested review from tillrohrmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slinkydeveloper @AhmedSoliman