Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug docker image #2294

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Debug docker image #2294

wants to merge 1 commit into from

Conversation

muhamadazmy
Copy link
Contributor

@muhamadazmy muhamadazmy commented Nov 14, 2024

Debug docker image

Summary:
While running the sdk-test-suite it was needed to rebuild
the restate docker image multiple times which is very time
consuming.

Now by running just debug-docker a quick debug image will
be made (at least on second time)

@muhamadazmy
Copy link
Contributor Author

NOTE: This will work only for linux users and possibly not always duo to difference in libc versions.

docker/debug.Dockerfile Outdated Show resolved Hide resolved
@slinkydeveloper
Copy link
Contributor

slinkydeveloper commented Nov 14, 2024

Hey, I worked on something like that before as well, maybe can be useful as reference https://github.com/restatedev/restate/pull/1913/files#diff-c619eafd655a2bbc0adc9b2b704c1f9ae253ccb77ddea1dd3de815ea6a8b9c62R1

Still everything is built within the container, but after the first time this will be super fast to build the next times.

@muhamadazmy
Copy link
Contributor Author

@slinkydeveloper Thank you for your input. I am wondering why your PR was never merged ?

@slinkydeveloper
Copy link
Contributor

@muhamadazmy I never had time to finish it, and i didn't manage the enable the cache in CI, but locally it works fine! So it could be a good fit for just docker-debug

Summary:
While running the sdk-test-suite it was needed to rebuild
the restate docker image multiple times which is very time
consuming.

Now by running `just debug-docker` a quick debug image will
be made
@muhamadazmy
Copy link
Contributor Author

@slinkydeveloper Thank you. I reused the docker file from your PR. It's better to also run the build inside a builder stage to avoid issues with libc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants