Always clean up leadership state if the partition processor stops #2295
+39
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is important to always fail the pending rpcs if the partition processor stops. Otherwise the ingress might be hanging because a partition processor failure does not entail a process crash.
AhmedSoliman
approved these changes
Nov 14, 2024
Comment on lines
+272
to
+273
| Ok(_) => warn!("Shutting partition processor down because it stopped unexpectedly."), | ||
| Err(err) => warn!("Shutting partition processor down because it failed: {err}"), |
There was a problem hiding this comment.
Should these be error! or is there a case where this is okay to happen?
There was a problem hiding this comment.
It can happen if we fail to find the tail, for example. In this case, it's up to the PPM to handle this situation. Right now it would stop the PP and wait for further instructions from the CC. But maybe warn is too high since it can also happen when shutting down. The PPM would have the context to distinguish a shut down case from an unexpected termination.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is important to always fail the pending rpcs if the partition processor
stops. Otherwise the ingress might be hanging because a partition processor
failure does not entail a process crash.
The very concrete problem that I observed was when shutting down a PP, we are also shutting down the corresponding invoker. If shutting down the invoker completes first, then we would fail when
become_followerwhere we check theabort_handleand never complete the pending rpcs.