Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added flag to track replaying awareness of tracing span #20

Closed
wants to merge 1 commit into from
Closed

Added flag to track replaying awareness of tracing span #20

wants to merge 1 commit into from

Conversation

h7kanna
Copy link

@h7kanna h7kanna commented Oct 30, 2024

Change to support restatedev/sdk-rust#30

slinkydeveloper
slinkydeveloper reviewed Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@slinkydeveloper slinkydeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I answered on the sdk-rust PR, let's continue the conversation there.

@h7kanna
Copy link
Author

h7kanna commented Oct 30, 2024

Closing, this is not needed as the flag needed can be maintained in the SDK context.

@h7kanna h7kanna closed this Oct 30, 2024
@h7kanna h7kanna deleted the replay-aware-tracing-flag branch October 30, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slinkydeveloper slinkydeveloper slinkydeveloper left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h7kanna @slinkydeveloper