Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CompleteAwakeableEntryMessage.failure #44

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Add CompleteAwakeableEntryMessage.failure #44

merged 1 commit into from
Aug 15, 2023

Conversation

slinkydeveloper
Copy link
Contributor

Part of restatedev/restate#678, to achieve API symmetry we should allow SDKs to implement an API to fail awakeables.

tillrohrmann
tillrohrmann approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merging. This will probably also require an update for the SDKs.

@slinkydeveloper slinkydeveloper merged commit fcfe65f into main Aug 15, 2023
2 checks passed
@slinkydeveloper slinkydeveloper deleted the issues/43 branch August 15, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slinkydeveloper @tillrohrmann