Modify End of Stream #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
approved these changes
Dec 4, 2023
slinkydeveloper
force-pushed
the
issues/49
branch
from
f783565
to
248766b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify end of stream logic. This change simplifies the end of stream, to accommodate it for restatedev/restate#899, by introducing an explicit end of stream message. This is a breaking change, as now the stream cannot end anymore with only
OutputStreamEntry. This message could also be used in future to pass metadata about the invocation, such as headers to pass back to the caller, diagnostic meta such as execution time, and so on.