Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Better error messages for references to undefined memory locations #1304

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix: Better error messages for references to undefined memory locations #1304

wants to merge 1 commit into from

Conversation

notmgsk
Copy link
Contributor

@notmgsk notmgsk commented Mar 8, 2021

Description

Provide a better error message when qc.run(binary, memory_map=...) includes:

  • reference to undefined memory name; or
  • more parameter values than are expected

Checklist

  • The above description motivates these changes.
  • There is a unit test that covers these changes.
  • All new and existing tests pass locally and on Travis CI.
  • Parameters and return values have type hints with PEP 484 syntax.
  • Functions and classes have useful Sphinx-style docstrings.
  • All code follows Black style and obeys flake8 conventions.
  • (New Feature) The docs have been updated accordingly.
  • (Bugfix) The associated issue is referenced above using auto-close keywords.
  • The changelog is updated, including author and PR number (@username, gh-xxx).

kalzoo
kalzoo requested changes Mar 11, 2021
View reviewed changes
pyquil/api/_qpu.py
if k.name not in patch_values:
raise KeyError(f"{k.name} is not one of the valid memory descriptors: {patch_values.keys()}")
if k.index >= len(patch_values[k.name]):
raise IndexError(f"{k.name} has more parameter values ({k.index}) than expected ({len(patch[k.name])})")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is len(patch[k.name]) supposed to be len(patch_values[k.name])?

On that note, it could be worth adding a simple test case. Even with 3.x in the works, 2.x will be in use for a long tail

@ameyer-rigetti
Copy link
Contributor

@notmgsk Are you still interested in having this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalzoo kalzoo kalzoo requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@notmgsk @ameyer-rigetti @kalzoo