Support swift package manager v4 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I bumped into a problem when building on Linux(dockerhub) 😭 CommonCrypt is only available at iOS/Mac. |
|
Yeah. That is true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, I need to say this changes are still not perfect because daltoniam/zlib-spm and daltoniam/Starscream didn't support Swift PM v4 yet. So I fork these and add changes to support it. You can check my changes via following pages.
There is a problem when sending a Pull Request to Starscream because C header files are moved inside
includedirectory to support Swift PM v4 cause of constraints to support C language targets (See https://github.com/apple/swift-package-manager/blob/master/Documentation/Usage.md#c-language-targets for more details).So maybe Starscream builds in XCode will be failed cause of changing directory of header files.