WIP: refactor svg #3673
Closed
WIP: refactor svg #3673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahankinson
reviewed
May 8, 2024
|
Coming back to this, I prefer not to touch it. The way the SVG is supported by various SVG renderers has been carefully adjusted and I don't see the need to change it for SharpVectors. My experience has shown that changing things like this will quite likely break rendering with another SVG renderer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to get rid of the unwanted css attribute
overflowfrom the SVG output.Instead of extracting the symbols from each font the paths are put in a g element for referencing in the SVG.
That removes the previous need for a
@viewboxon every glyph and the later resizing with@widthand@hight(making the resulting SVG way smaller).The scaling for the glyphs is added during adding the snippets in Verovio.
Currently it is hard-coded, so scaling with this doesn't work.