Added the Ability to Use Rectilinear Polygons in the Dynamic Zone Block #654
+86
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandlersupple
requested review from
PawelPeczek-Roboflow,
grzegorz-roboflow,
yeldarby,
probicheaux and
hansent
as code owners
grzegorz-roboflow
requested changes
Sep 19, 2024
| contours = sv.mask_to_polygons(mask) | ||
| largest_contour = max(contours, key=len) | ||
|
|
||
| # https://docs.opencv.org/4.x/d3/dc0/group__imgproc__shape.html#ga014b28e56cb8854c0de4a211cb2be656 | ||
| if force_rectangle and required_number_of_vertices == 4: |
There was a problem hiding this comment.
I'd move this to the run function and keep all logic relevant to forced rectangle together
| if len(simplified_polygon) != required_number_of_vertices: | ||
| continue | ||
| simplified_polygons.append(simplified_polygon) | ||
| if force_rectangle and required_number_of_vertices == 4: |
There was a problem hiding this comment.
I'd vote to raise exception at the beginning of run method if force_rectangle is true and requested number of vertices was not set to 4.
There was a problem hiding this comment.
Got it. Thanks for flagging this @grzegorz-roboflow. I'll move the logic to the run function.
|
@chandlersupple could you please follow up on @grzegorz-roboflow comments - otherwise it may not be pushed into next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added two optional parameters to the Dynamic Zone block allowing users to use rectangles instead of irregular polygons, and get the height, width, and angle of the rectangles.
Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
Passed all tests. Added the
test_calculate_minimum_bounding_rectangletest.Any specific deployment considerations
N/A
Docs
N/A