-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add model yolo-nas #27
base: develop
Are you sure you want to change the base?
Conversation
Thank you for your contribution @quangdungluong! I'll verify and merge it today! |
Hi @quangdungluong, The code looks great! I have a few questions: DependenciesI've updated the supervision version in However, on neither of my machines (mac, linux) can I resolve the dependencies successfully. Did Also, would you mind reinstalling it and rerunning the results? The updated supervision version may give more accurate results. Model parametersIdeally we'd like to replicate the parameters used to benchmark the models originally. I see you used the following - did you have the chance to dig any deeper to check what values YOLO-NAS authors suggested for validation? Personally, I couldn't find any.
|
Hi @LinasKo, DepedenciesI have created a new environment and run pip install -r requirements.txt. The code runs directly without needing to install anything else. I also updated to the new version of Supervision and reran the results. Model parametersI have dug deeper into the YOLO-NAS documentation and found the post-processing parameters they use for validation when training models. Based on those values, I reran the code and obtained new results. |
Hey @quangdungluong, Thank you very much for your contribution! Just in case, I'll leave this open for a bit, see if I can get in contact with the authors to check whether we're running it in an optimal way. The code looks great. We can merge as soon as we:
|
Description
Add model yolo-nas inference with results
Type of change
Please delete options that are not relevant.