tracker_id contents are never None
#1214
Conversation
|
fyi, @LinasKo collab access is not public |
|
@onuralpszr, thank you - I've opened it up |
|
@LinasKo how about make another rc release with it ? For better tracker fix ? |
That's outside my area of responsibility 🙂 Our main goal, however, is working towards the new release, rather than pushing out more candidate packages. |
|
Hi @onuralpszr 👋🏻 why do you think we should release a new rc? |
Well, current release has tracker issue and with those fix and this extra addition should be live for others to easy to use. Personally, I wish we should do point release instead of major release. |
|
I can also update current doc version without even change version number If you like (like last time we did) |
I understand. I'm also not particularly happy that the latest version has had this bug for so long, but we will have the next release soon – in a week. We still have some inconsistencies, such as #1215. I would prefer to resolve these before the release. |
If time is close, We should be fine. |
Description
I've verified every instance of
tracker_idin our repo, and found that its contents are neverNone.The checks we have are not necessary.
In cases where
tracker_idgets-1added, it is indeed filtered out very soon.Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Basic tests of smoother and line counter can be found here: https://colab.research.google.com/drive/1_gajR0D_CZ4Z2dZ1y8SdVaWGbDZ0mBpl?usp=sharing
Even with no detections for longer periods of time, no errors (and no None values) are produced.
Any specific deployment considerations
None
Docs