Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple Command from Relation #613

Closed
wants to merge 1 commit into from
Closed

Decouple Command from Relation #613

wants to merge 1 commit into from

Conversation

solnic
Copy link
Member

@solnic solnic commented Dec 13, 2020 •
edited
Loading

This is a long-time coming massive simplification of internals that results in better design. Once done, this will make building new features and fixing any command-related bugs easier.

TODO

  • Make commands use datasets instead of relations
  • Make building commands work again
  • Make compiling commands work again
  • Make commands use schemas
    • Add schema option
    • Infer input_proc from schema
    • Infer output_proc from schema (this is now used in rom-sql but it should be in the core)
  • Fix command graphs
  • Fix lazy commands
  • Update rom-sql too (this is also needed to make specs pass over here) - see Decouple Command from Relation rom-sql#387

Closes #605

@solnic solnic mentioned this pull request Dec 13, 2020
Draft
@solnic solnic added this to the 6.0.0 milestone Dec 13, 2020
@solnic solnic force-pushed the decouple-commands-from-relations branch from af60025 to cbdbd59 Compare December 29, 2020 11:54
@solnic solnic force-pushed the decouple-commands-from-relations branch from cbdbd59 to c257268 Compare March 11, 2021 18:23
@solnic solnic force-pushed the decouple-commands-from-relations branch from c257268 to 8002443 Compare March 22, 2021 09:32
@solnic solnic modified the milestones: 6.0.0, 7.0.0 Apr 15, 2021
@solnic solnic added the on-hold label May 6, 2021
@viezly
Copy link

viezly bot commented Jun 10, 2021 •
edited
Loading

Full changes overview:

Show details on Viezly ➡️

@solnic solnic closed this Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
on-hold
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Decouple Command from Relation
1 participant
@solnic