Update RdpClientFactory to actually create a instance of the native control #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @haefele, much appreciated! I will merge and also do some test on my side. A new nuget will be published afterwards. cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some issues when trying to use the RdpControl on a Windows Server 2019.
I would always get this error message:
It seems like the
RdpClient12is actually not available on Windows Server 2019, but theRdpClientFactorydidn't notice.The RdpControl would try to use a RdpClient12, and then fail with the exception in the screenshot above.
The proposed change tries to create an instance of the native RDP control, and only if that is successful the RdpClient will be used.
This change does fix the issue on WIndows Server 2019 for me.
I would highly appreciate having this change merged and a new nuget-package published.