tabsetPanel binding: unconditionally trigger change on receiveMessage

This brings it into line with all of the other input bindings. The only exception is sliderInput, which has a more complicated codepath that goes out of its way to force the slider, for its own reasons; I didn't change the slider for fear of breaking something, and it also doesn't exhibit the problem I'm here to fix (next paragraph). The goal is to ensure that if forgetLastInput is called on an input, and then that input receives a message (updateXXXInput) to update its value, BUT the new value is the SAME as its existing value, that the input binding still acts like something changed. This is because we need the id/value to go through the InputSender code path, and alert the server if a previously frozen input is now thawed.
rstudio · Oct 6, 2020 · bf9f3b7 · bf9f3b7
1 parent 0f34097
commit bf9f3b7
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 3 deletions.
diff --git a/inst/www/shared/shiny.js b/inst/www/shared/shiny.js
diff --git a/inst/www/shared/shiny.js.map b/inst/www/shared/shiny.js.map
diff --git a/inst/www/shared/shiny.min.js b/inst/www/shared/shiny.min.js
diff --git a/inst/www/shared/shiny.min.js.map b/inst/www/shared/shiny.min.js.map
diff --git a/srcjs/input_binding_tabinput.js b/srcjs/input_binding_tabinput.js
@@ -36,6 +36,7 @@ $.extend(bootstrapTabInputBinding, {
   receiveMessage: function(el, data) {
     if (data.hasOwnProperty('value'))
       this.setValue(el, data.value);
+    $(el).trigger("change");
   },
   subscribe: function(el, callback) {
     $(el).on('change shown.bootstrapTabInputBinding shown.bs.tab.bootstrapTabInputBinding', function(event) {