Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When initializing inputs, make sure their values actually get to server #2975

Closed
wants to merge 1 commit into from
Closed

When initializing inputs, make sure their values actually get to server #2975

wants to merge 1 commit into from

Conversation

jcheng5
Copy link
Member

@jcheng5 jcheng5 commented Jul 17, 2020

Partial fix for #1791

Also necessary for some client-side validation logic I'm developing, details to come

@jcheng5
Copy link
Member Author

jcheng5 commented Sep 15, 2020

After discussing with @wch, this seems overbroad. In cases where freezeReactiveValue wasn't used, this would cause unnecessary invalidations.

I'll create a new PR with a more surgical fix: when freezeReactiveValue is applied to an input, the client is notified and flags that input. The next time the input is set, deduplication will not apply. This should fix both renderUI and updateXXXInput cases at once.

@jcheng5 jcheng5 closed this Sep 15, 2020
@jcheng5
Copy link
Member Author

jcheng5 commented Oct 7, 2020

Superceded by #3055

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jcheng5