Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Performance/CaseWhenSplat cop error on when node without body #484

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

viralpraxis
Copy link
Contributor

Previously if when node has an empty body this cop raises:

case 1
when 1 # no body
  # 1 == 1
else
  nil
end
undefined method `loc' for nil
    # ./lib/rubocop/cop/performance/case_when_splat.rb:154:in `indent_for'
    # ./lib/rubocop/cop/performance/case_when_splat.rb:144:in `new_branch_without_then'
    # ./lib/rubocop/cop/performance/case_when_splat.rb:123:in `reordering_correction'
    # ./lib/rubocop/cop/performance/case_when_splat.rb:114:in `reorder_condition'
    # ./lib/rubocop/cop/performance/case_when_splat.rb:86:in `autocorrect'

It also did not preserve comments.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@viralpraxis viralpraxis force-pushed the fix-performance-case-when-splat-cop-error-on-when-without-body branch from 4d08bc3 to ad77376 Compare January 15, 2025 06:21
Previously if `when` node has an empty body this cop raises:

```ruby
case 1
when 1 # no body
  # 1 == 1
else
  nil
end
```

```
undefined method `loc' for nil
    # ./lib/rubocop/cop/performance/case_when_splat.rb:154:in `indent_for'
    # ./lib/rubocop/cop/performance/case_when_splat.rb:144:in `new_branch_without_then'
    # ./lib/rubocop/cop/performance/case_when_splat.rb:123:in `reordering_correction'
    # ./lib/rubocop/cop/performance/case_when_splat.rb:114:in `reorder_condition'
    # ./lib/rubocop/cop/performance/case_when_splat.rb:86:in `autocorrect'
```

It also did not preserve comments.
@viralpraxis viralpraxis force-pushed the fix-performance-case-when-splat-cop-error-on-when-without-body branch from ad77376 to a1a7c35 Compare January 15, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant