Enable a few pending cops

- Lint/AmbiguousOperatorPrecedence
- Lint/NonAtomicFileOperation
- Style/ReturnNilInPredicateMethodDefinition
- RSpec/ReceiveMessages (not sure now we missed that one)

.rubocop.yml

@@ -126,12 +126,18 @@ Layout/LineContinuationSpacing:
   Enabled: true
 Layout/LineEndStringConcatenationIndentation:
   Enabled: true
+Lint/AmbiguousOperatorPrecedence:
+  Enabled: true
+Lint/NonAtomicFileOperation:
+  Enabled: true
 Style/EmptyHeredoc:
   Enabled: true
 Style/RedundantHeredocDelimiterQuotes:
   Enabled: true
 Style/RedundantStringEscape:
   Enabled: true
+Style/ReturnNilInPredicateMethodDefinition:
+  Enabled: true
 
 # Enable our own pending cops.
 
@@ -167,6 +173,8 @@ RSpec/NoExpectationExample:
   Enabled: true
 RSpec/PendingWithoutReason:
   Enabled: true
+RSpec/ReceiveMessages:
+  Enabled: true
 RSpec/RedundantAround:
   Enabled: true
 RSpec/SkipBlockInsideExample:

spec/support/file_helper.rb

@@ -19,6 +19,6 @@ def create_file(file_path, content)
 
   def create_dir(file_path)
     dir_path = File.dirname(file_path)
-    FileUtils.makedirs dir_path unless File.exist?(dir_path)
+    FileUtils.makedirs dir_path
   end
 end