Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false negative for RSpecRails/TravelAround cop when passed as a proc to a travel method #59

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

ydah
Copy link
Member

@ydah ydah commented Feb 13, 2025

Fixes: #49


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

  • [-] Added the new cop to config/default.yml.
  • [-] The cop is configured as Enabled: pending in config/default.yml.
  • [-] The cop documents examples of good and bad code.
  • [-] The tests assert both that bad code is reported and that good code is not reported.
  • [-] Set VersionAdded: "<<next>>" in default/config.yml.

If you have modified an existing cop's configuration options:

  • [-] Set VersionChanged: "<<next>>" in config/default.yml.

@ydah ydah requested a review from a team as a code owner February 13, 2025 08:55
@bquorning
Copy link
Contributor

Why do we prefer before over around?

@ydah
Copy link
Member Author

ydah commented Feb 13, 2025

@bquorning this cops motivation is here:

Since Rails 5.2, travel_back is called automatically, so you can easily do that by just calling it in before instead of using around with nested blocks.

refs: rubocop/rubocop-rspec#1503

@ydah ydah merged commit 2d257f2 into master Feb 14, 2025
27 checks passed
@ydah ydah deleted the issue49 branch February 14, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TravelAround cop does not detect around block when the block is passed as a proc using
2 participants