Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RuboCop RSpecRails work as a RuboCop plugin #61

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

bquorning
Copy link
Contributor

@bquorning bquorning commented Feb 17, 2025

This pull request adds support for RuboCop's plugin feature, added in rubocop/rubocop#13792, released in v1.72.

It replaces the ad-hoc inject_defaults! with RuboCop plugins.

Some Rake tasks may still need to use inject_defaults!.


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@bquorning bquorning marked this pull request as ready for review February 17, 2025 08:49
@bquorning bquorning requested a review from a team as a code owner February 17, 2025 08:49
This pull request adds support for RuboCop's plugin feature, added in
rubocop/rubocop#13792, released in v1.72.

It replaces the ad-hoc `inject_defaults!` with RuboCop plugins.

Some Rake tasks may still need to use `inject_defaults!`.
@bquorning
Copy link
Contributor Author

cc @ydah

@ydah ydah merged commit 64bfac4 into master Feb 18, 2025
27 checks passed
@ydah ydah deleted the rubocop-plugin branch February 18, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants