add basic style definition #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satoryu
requested changes
Oct 9, 2023
lib/docx/document.rb
Outdated
Comment on lines
213
to
215
| p = Elements::Containers::Paragraph.new(p_node, document_properties) | ||
| p.document = self | ||
| p |
There was a problem hiding this comment.
#document= looks much open: anybody can replace another Document instance with this accessor of the paragraph returned.
how about giving Document object to Paragraph's constructor like Element::Containers::Paragraph.new(p_node, document_properties, self) ?
There was a problem hiding this comment.
yes it's ok, my initial idea was to avoid modifying previous API.
I modify branch to take into account.
spec/docx/document_spec.rb
Outdated
|
|
||
| describe 'reading style' do | ||
| before do | ||
| @doc = Docx::Document.open(@fixtures_path + '/test_with_style.docx') |
…rough paragrah constructor
satoryu
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I see that style is not given for paragraph, If you want I propose a minimalist implementation of style.
With it you can have the name of the style by paragraph.
The main API is style(), called for a paragraph it returns it style name. As the style are stored in document, I have added an API to access to document in paragraph class.
Can you review please ? Any suggestions are welcome !
Regards,