Use Promise in example for #evaluate_async #325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #234
I couldn't remember how to get a value back from
evaluate_async
and remembered I had created an example in a previous issue.The existing example leverages
arguments[0]
and calls a simple object. Instead, I would like to see an actual, practical example using familiar things that people would commonly use this for.Additionally, I think we should encourage usage of
__f()
as in the next example, instead ofarguments[0]
, or rework the#evaluate_async
template. As an example, if you call:arguments[0]
no longer refers to the fulfill callback. You end up receivingTypeError: arguments[0] is not a function (Ferrum::JavaScriptError)
.Perhaps this highlights some tweaks that could be made to
evaluate_async
, but for now, I'd like to get this docs change up asap.