feat(api): add ShowResult attribute to plan response #4777
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulsh
requested review from
GenPage,
lukemassa and
X-Guardian
and removed request for
a team
github-actions
bot
added
docs
raulsh
changed the title
raulsh
changed the title
chenrui333
reviewed
Jul 23, 2024
There was a problem hiding this comment.
Can you add some test per this change?
|
ping @raulsh |
|
@raulsh Do you have time to finish this PR? Thanks. |
|
This issue is stale because it has been open for 1 month with no activity. Remove stale label or comment or this will be closed in 1 month. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Add new ShowResult attribute in /api/plan endpoint. It reads show output file and put into API response.
why
It allows to use JSON output to create new implementations/tools based on this instead of plain text Terraform output. In my case, I can build a drift detection tools that relies on Atlantis plan execution (instead of executing plan on separate environment).
Even I tried with https://github.com/cresta/atlantis-drift-detection. But just uses Atlantis just to check if a project have changes and locking state if need to do a plan. But after that, it needs to execute a plan outside Atlantis.
tests
references