Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update gitlab links #5341

Merged
merged 1 commit into from
Feb 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e/gitlab.go
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ func (g GitlabClient) DeleteBranch(ctx context.Context, branchName string) error
}

func (g GitlabClient) IsAtlantisInProgress(state string) bool {
// From https://docs.gitlab.com/ee/api/pipelines.html
// From https://docs.gitlab.com/api/pipelines/
// created, waiting_for_resource, preparing, pending, running, success, failed, canceled, skipped, manual, scheduled
for _, s := range []string{"success", "failed", "canceled", "skipped"} {
if state == s {
Expand Down
2 changes: 1 addition & 1 deletion runatlantis.io/contributing/events-controller.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ documentation.
- [Azure DevOps Pull Request Created](https://learn.microsoft.com/en-us/azure/devops/service-hooks/events?view=azure-devops#pull-request-created)
- [BitBucket Pull Request](https://support.atlassian.com/bitbucket-cloud/docs/event-payloads/#Pull-request-events)
- [GitHub Pull Request](https://docs.github.com/en/webhooks/webhook-events-and-payloads#pull_request)
- [GitLab Merge Request](https://docs.gitlab.com/ee/user/project/integrations/webhook_events.html#merge-request-events)
- [GitLab Merge Request](https://docs.gitlab.com/user/project/integrations/webhook_events/#merge-request-events)
- [Gitea Webhooks](https://docs.gitea.com/next/usage/webhooks)

</details>
Expand Down
2 changes: 1 addition & 1 deletion runatlantis.io/docs/access-credentials.md
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ A new permission for `Actions` has been added, which is required for checking if

### GitLab

* Follow: [GitLab: Create a personal access token](https://docs.gitlab.com/ce/user/profile/personal_access_tokens.html#create-a-personal-access-token)
* Follow: [GitLab: Create a personal access token](https://docs.gitlab.com/user/profile/personal_access_tokens/#create-a-personal-access-token)
* Create a token with **api** scope
* Record the access token

Expand Down
4 changes: 2 additions & 2 deletions runatlantis.io/docs/command-requirements.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ The `approved` requirement by:
Each VCS provider has different rules around who can approve:

* **GitHub** – **Any user with read permissions** to the repo can approve a pull request
* **GitLab** – The user who can approve can be set in the [repo settings](https://docs.gitlab.com/ee/user/project/merge_requests/approvals/)
* **GitLab** – The user who can approve can be set in the [repo settings](https://docs.gitlab.com/user/project/merge_requests/approvals/)
* **Bitbucket Cloud (bitbucket.org)** – A user can approve their own pull request but
Atlantis does not count that as an approval and requires an approval from at least one user that
is not the author of the pull request
Expand Down Expand Up @@ -303,6 +303,6 @@ request can run the actual `atlantis apply` command.
## Next Steps

* For more information on GitHub pull request reviews and approvals see: [GitHub: About pull request reviews](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews)
* For more information on GitLab merge request reviews and approvals (only supported on GitLab Enterprise) see: [GitLab: Merge request approvals](https://docs.gitlab.com/ee/user/project/merge_requests/approvals/).
* For more information on GitLab merge request reviews and approvals (only supported on GitLab Enterprise) see: [GitLab: Merge request approvals](https://docs.gitlab.com/user/project/merge_requests/approvals/).
* For more information on Bitbucket pull request reviews and approvals see: [BitBucket: Use pull requests for code review](https://confluence.atlassian.com/bitbucket/pull-requests-and-code-review-223220593.html)
* For more information on Azure DevOps pull request reviews and approvals see: [Azure DevOps: Create pull requests](https://docs.microsoft.com/en-us/azure/devops/repos/git/pull-requests?view=azure-devops&tabs=browser)
2 changes: 1 addition & 1 deletion runatlantis.io/guide/testing-locally.md
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ TOKEN="{YOUR_TOKEN}"

### GitLab or GitLab Enterprise Access Token

- follow [GitLab: Create a personal access token](https://docs.gitlab.com/ce/user/profile/personal_access_tokens.html#create-a-personal-access-token)
- follow [GitLab: Create a personal access token](https://docs.gitlab.com/user/profile/personal_access_tokens/#create-a-personal-access-token)
- create a token with **api** scope
- set the token as an environment variable

Expand Down
Loading