Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Dude, Where's My Stuff?" to v2.7.0 #6252

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Thource
Copy link
Contributor

@Thource Thource commented Jul 6, 2024

@runelite-github-app
Copy link

runelite-github-app bot commented Jul 6, 2024

Includes non-plugin changes

dude-wheres-my-stuff: 749e63ef6871ae27d45b5ac401e1b716e1c95fae...19dc452292300d48d96ce0fa14a905ee6409c875

@Thource
Copy link
Contributor Author

Thource commented Aug 14, 2024

Sorry, trying to create a PR for hotfix and accidentally pushed to this branch

@Felanbird
Copy link
Contributor

@Thource as a reminder you pushed this branch to have no changes, also I pushed this plugin back 1 commit to before the cat_h changes, just so you are aware when/if you resolve this PR.

@Thource
Copy link
Contributor Author

Thource commented Sep 14, 2024

Thanks @Felanbird, I believe this should be ready now

Comment on lines +1420 to +1427
<component group="org.xerial" name="sqlite-jdbc" version="3.46.0.0">
<artifact name="sqlite-jdbc-3.46.0.0.jar">
<sha256 value="e697df15be3f95219d80773c5f1002030e33e932adda186c1c86fd51df6691a9" origin="Generated by Gradle"/>
</artifact>
<artifact name="sqlite-jdbc-3.46.0.0.pom">
<sha256 value="3c16325e9917957ada3cda84fb50296145aa4f3aa73e7a5d63af9719cee2a7ac" origin="Generated by Gradle"/>
</artifact>
</component>
Copy link

@jaybyrrd jaybyrrd Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I missing something? This doesn't actually seem different, just moved.

@LlemonDuck
Copy link
Contributor

Is there a reason you need the newer gsheets dependency? Does v4-rev581-1.25.0, which is already approved, no longer work?

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Nov 12, 2024
@LlemonDuck LlemonDuck closed this Nov 12, 2024
@LlemonDuck LlemonDuck reopened this Nov 12, 2024
@Thource
Copy link
Contributor Author

Thource commented Nov 12, 2024 via email

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants