Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update monster-monitor to v1.3.5 #6949

Merged
merged 7 commits into from
Nov 10, 2024

Conversation

ChunkyAtlas
Copy link
Contributor

Refactor MonsterMonitorOverlay with thread-safe NPC tracking, customizable settings, and improved rendering

  • Changed tracked NPCs list to an AtomicReference for thread-safe updates.
  • Added 'showTitle' config option to control visibility of the overlay title.
  • Replaced title rendering logic to respect the 'showTitle' configuration.
  • Simplified progress bar rendering into a dedicated drawProgressBar method for clarity and reusability.
  • Updated progress color logic with the getBarColor method for improved readability.
  • Switched from TitleComponent to direct string drawing for title, aligning with new rendering approach.
  • Updated README

fix: refine MonsterMonitorPanel UI and improve code structure

- Adjusted `MonsterMonitorPanel` scrolling behavior by replacing `npclistpanel` scroll pane with a simple `JPanel`.
- Moved `customScrollbarUI` method from `MonsterMonitorPlugin` to `MonsterMonitorPanel` for better encapsulation.
- Reduced font size on `Notify` checkbox, `Limit` spinner, and `Set Limit` checkbox for a cleaner UI.
- Modified `FINAL_PHASE_IDS` to support multi-ID bosses, adding support for Verzik Vitur.
fix: refine MonsterMonitorPanel UI and improve code structure

- Adjusted `MonsterMonitorPanel` scrolling behavior by replacing `npclistpanel` scroll pane with a simple `JPanel`.
- Moved `customScrollbarUI` method from `MonsterMonitorPlugin` to `MonsterMonitorPanel` for better encapsulation.
- Reduced font size on `Notify` checkbox, `Limit` spinner, and `Set Limit` checkbox for a cleaner UI.
- Modified `FINAL_PHASE_IDS` to support multi-ID bosses, adding support for Verzik Vitur.
Add NPC name truncation in overlay and Edit NPC Data option

Truncate long NPC names in the overlay’s progress bar to keep it neat and readable

Set a character limit and added a method to shorten names with "..." if they’re too long
Applied this truncation in MonsterMonitorOverlay before drawing names
Added an "Edit NPC Data" option in the context menu to allow in-game editing of NPC tracking info

Created a dialog that lets users adjust Total Kills, Kill Limit, and Kills For Limit directly
Updated MonsterMonitorBox to include this option, making it easier to manage tracked NPCs
Changes made in the dialog sync automatically with the overlay and panel for immediate updates
Refactor MonsterMonitorOverlay with thread-safe NPC tracking, customizable settings, and improved rendering

- Changed tracked NPCs list to an AtomicReference for thread-safe updates.
- Added 'showTitle' config option to control visibility of the overlay title.
- Replaced title rendering logic to respect the 'showTitle' configuration.
- Simplified progress bar rendering into a dedicated drawProgressBar method for clarity and reusability.
- Updated progress color logic with the getBarColor method for improved readability.
- Switched from TitleComponent to direct string drawing for title, aligning with new rendering approach.
- Updated README
@runelite-github-app
Copy link

@LlemonDuck LlemonDuck merged commit 3678f88 into runelite:master Nov 10, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants