-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Distraction reducer #6966
Merged
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toa detection change and added more enchantment IDs
commit: Add bonfire firemaking support and improve movement detection - Added support for adding logs to bonfires with correct animation IDs - Added firemaking toggle to config section - Improved movement detection by tracking both animation poses and position changes - Added immediate overlay clearing when movement is detected - Excluded manual tinderbox firemaking animations - Added debug logging for overlay visibility changes Animation IDs added for bonfire firemaking: - Regular logs (10565) - Oak logs (10569) - Willow logs (10572) - Maple logs (10568) - Yew logs (10573) - Magic logs (10566) - Redwood logs (10570)
Changed config option of bake pie to prevent false positives of contact NPC
|
tylerwgrass
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI you removed STRING_JEWELRY_ANIMATION_IDS
, not sure if that was intentional
LlemonDuck
added
the
waiting for author
waiting for the pr author to make changes or respond to questions
label
Nov 14, 2024
It should be removed and I'll address a better way to handle it in the future |
runelite-github-app
bot
removed
the
waiting for author
waiting for the pr author to make changes or respond to questions
label
Nov 14, 2024
iProdigy
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed config option of bake pie to prevent false positives of contact NPC