Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Distraction reducer #6966

Merged
merged 7 commits into from
Nov 14, 2024
Merged

Conversation

Car-Role
Copy link
Contributor

Changed config option of bake pie to prevent false positives of contact NPC

toa detection change and added more enchantment IDs
commit: Add bonfire firemaking support and improve movement detection

- Added support for adding logs to bonfires with correct animation IDs
- Added firemaking toggle to config section
- Improved movement detection by tracking both animation poses and position changes
- Added immediate overlay clearing when movement is detected
- Excluded manual tinderbox firemaking animations
- Added debug logging for overlay visibility changes

Animation IDs added for bonfire firemaking:
- Regular logs (10565)
- Oak logs (10569) 
- Willow logs (10572)
- Maple logs (10568)
- Yew logs (10573)
- Magic logs (10566)
- Redwood logs (10570)
Changed config option of bake pie to prevent false positives of contact NPC
@runelite-github-app
Copy link

@Car-Role Car-Role changed the title Distraction reducer Update Distraction reducer Nov 12, 2024
Copy link
Member

@tylerwgrass tylerwgrass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI you removed STRING_JEWELRY_ANIMATION_IDS, not sure if that was intentional

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Nov 14, 2024
@Car-Role
Copy link
Contributor Author

It should be removed and I'll address a better way to handle it in the future

@tylerwgrass

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Nov 14, 2024
@iProdigy iProdigy merged commit 3077be5 into runelite:master Nov 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants