Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare switch to GHMQ #464

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Jun 20, 2023

Bors has been non-responsive for a few days.

@eldruin eldruin requested a review from a team as a code owner June 20, 2023 08:21
Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg rustup is now broken too? :(

pull_request:
push: # Run CI for all branches except GitHub merge queue tmp branches
branches-ignore:
- "gh-readonly-queue/**"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary? I thought it was only useful for non-GHA CI to trigger builds on merge queue commits.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes CI not run on these branches.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but why are we telling GHA to not run on that branch?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you do both "on push to any branch" and "on merge group", when GHMQ pushes to gh-readonly-queue/blahblah it matches both which I think triggers duplicate builds.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, this avoids duplicate runs. It is taken from here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only necessary if you don't set branches for the push event to work on.

@adamgreig
Copy link
Member

Could you also delete bors.toml?

@Dirbaio
Copy link
Member

Dirbaio commented Jun 20, 2023

Could you also delete bors.toml?

it's already deleted

@Dirbaio Dirbaio added this pull request to the merge queue Jun 20, 2023
Merged via the queue into rust-embedded:master with commit 3620083 Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants