Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub workflows #132

Merged
merged 12 commits into from
May 16, 2023
Merged

Update GitHub workflows #132

merged 12 commits into from
May 16, 2023

Conversation

romancardenas
Copy link
Contributor

@romancardenas romancardenas commented May 8, 2023

With all the bors thing going on, I've been reading a bit about merge queues etc. and noticed that some of our workflows still use outdated/deprecated actions. This PR fixes this.

@romancardenas romancardenas requested a review from a team as a code owner May 8, 2023 14:16
dkhayes117
dkhayes117 previously approved these changes May 10, 2023
Copy link
Member

@dkhayes117 dkhayes117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@romancardenas
Copy link
Contributor Author

bors try

@bors
Copy link
Contributor

bors bot commented May 12, 2023

try

Configuration problem:
bors.toml: syntax error

@romancardenas
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request May 12, 2023
@bors
Copy link
Contributor

bors bot commented May 12, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@romancardenas
Copy link
Contributor Author

romancardenas commented May 12, 2023

Looks like the % wildcard in bors.toml only captures one hit. Does anyone know how to tell bors to check ALL the matches?

@romancardenas
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request May 12, 2023
@bors
Copy link
Contributor

bors bot commented May 12, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@romancardenas
Copy link
Contributor Author

I followed this idea and now it should work

Copy link
Contributor

@almindor almindor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@almindor
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented May 16, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit bba4de2 into rust-embedded:master May 16, 2023
@romancardenas romancardenas mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants