update ci #726
Merged
update ci #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emilgardis
commented
Jun 4, 2023
There was a problem hiding this comment.
one thing we lose with this is a gha problem matcher.
We can add one easily, but I feel like dtolnay/rust-toolchain should do that, but I know the author wants to keep it minimal
| steps: | ||
| - name: Done | ||
| run: exit 0 | ||
| run: jq --exit-status 'all(.result == "success")' <<< '${{ toJson(needs) }}' |
There was a problem hiding this comment.
preparation for merge queue
burrbull
approved these changes
Jun 4, 2023
|
Do we need to add |
|
I messed up svd2rust and svd PRs. |
|
this does not implement merge queue, did you enable it here @burrbull ? Going to do that separately |
|
#727 implements merge_group |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #724
remove all uses of actions-rs which use deprecated gha functions and is not maintained
removes specific clippy-check in favor of running clippy directly