Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

very good new binary size improvement #600

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Noratrieb
Copy link
Member

@Noratrieb Noratrieb commented Mar 22, 2024

this significantly improves binary size, we need to merge this ASAP

@Noratrieb
Copy link
Member Author

let me regress binary size to test this

@workingjubilee
Copy link
Member

slightly concerned that this may not actually work unless the changeset is on master due to the jank way GHA works.

@Noratrieb
Copy link
Member Author

ugh, it does! pull_request_target does that.

@Noratrieb
Copy link
Member Author

i can open a new PR for just the first commit to merge

@workingjubilee
Copy link
Member

yeah I am happy to optimistically merge that change.

@Noratrieb Noratrieb changed the title Use rustc from stage0 instead of stage0-sysroot very good new binary size improvement Mar 22, 2024
@Noratrieb
Copy link
Member Author

Noratrieb commented Mar 22, 2024

{"platform":"ubuntu-latest","reference":"350632","updated":"350632"}
{"platform":"windows-latest","reference":"135168","updated":"135168"}

either I'm bad at regressing binary size or getting it from stage0 doesn't quite work correctly and we really do need stage0-sysroot instead. I'm not very sure about that, who gets what from where when.

@workingjubilee
Copy link
Member

@Kobzol whoops.

@Kobzol
Copy link
Contributor

Kobzol commented Mar 23, 2024

I think that we need to use stage0-sysroot (but first, it needs to be fixed). stage0-sysroot isn't actually used almost anywhere, so that's probably the reason why this wasn't noticed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants