Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(resolve): Improve multi-MSRV workspaces #14569

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix(resolve): Improve multi-MSRV workspaces #14569

wants to merge 7 commits into from
+115 −52

Commits on Sep 19, 2024

  1. refactor(ws): Clarify what rust-version is used 

    For workflows like `cargo info`, this call will live on regardless of
what we do with the resolver.
    @epage
    epage committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    77af3c5 View commit details
    Browse the repository at this point in the history

  2. test(resolver): Have unit test for multi-msrv

    @epage
    epage committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ab42f77 View commit details
    Browse the repository at this point in the history

  3. test(msrv): Clarify version numbers

    @epage
    epage committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    14eae5a View commit details
    Browse the repository at this point in the history

  4. test(msrv): Clarify role of deps

    @epage
    epage committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    8139f78 View commit details
    Browse the repository at this point in the history

  5. test(msrv): Clarify the differences in deps

    @epage
    epage committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    3e735fb View commit details
    Browse the repository at this point in the history

  6. test(msrv): Show msrv resolver issue

    @epage
    epage committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    9692659 View commit details
    Browse the repository at this point in the history

  7. fix(resolve): Improve multi-MSRV workspaces 

    We do this by resolving for a package version that is compatible
with the most number of MSRVs within a workspace.

If a version requirement is just right, every package will get the
highest MSRV-compatible dependency.

If its too high, packages will get MSRV-incompatible dependency
versions.
This will happen regardless of what we do due to the nature of
`"fallback"`.

If its too low, packages with higher MSRVs will get older-than-necessary
dependency versions.
This is similar to the "some with and without MSRV" workspaces.
When locking dependencies, we do report to users when newer MSRV/SemVer
compatible dependencies are available to help guide them to upgrading if
desired.

Fixes rust-lang#14414
    @epage
    epage committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    178e308 View commit details
    Browse the repository at this point in the history