Maintain backwards compatibility for bitflags types #1096
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Between versions 0.17.x and git2-0.18.0, bitflags was updated from 1.x to 2.1 which reduced the amount of derived traits on bitflags types. This in turn broke backwards compatibility since now bitflags types no longer implement
PartialOrd
,Ord
andHash
.The changelog of bitflags 2.0.0 mentions that:
This fixes #1095.