Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classify FIXMEs - 4 #4232

Merged
merged 1 commit into from
Feb 23, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/fuchsia/x86_64.rs
Original file line number Diff line number Diff line change
@@ -102,7 +102,7 @@ cfg_if! {
.field("uc_stack", &self.uc_stack)
.field("uc_mcontext", &self.uc_mcontext)
.field("uc_sigmask", &self.uc_sigmask)
// FIXME: .field("__private", &self.__private)
// FIXME(debug): .field("__private", &self.__private)
.finish()
}
}
4 changes: 2 additions & 2 deletions src/unix/bsd/apple/b32/mod.rs
Original file line number Diff line number Diff line change
@@ -45,7 +45,7 @@ s! {
}

pub struct malloc_zone_t {
__private: [crate::uintptr_t; 18], // FIXME: keeping private for now
__private: [crate::uintptr_t; 18], // FIXME(macos): keeping private for now
}
}

@@ -84,7 +84,7 @@ cfg_if! {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.debug_struct("pthread_attr_t")
.field("__sig", &self.__sig)
// FIXME: .field("__opaque", &self.__opaque)
// FIXME(debug): .field("__opaque", &self.__opaque)
.finish()
}
}
2 changes: 1 addition & 1 deletion src/unix/bsd/apple/b64/aarch64/mod.rs
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@ pub type mcontext_t = *mut __darwin_mcontext64;

s! {
pub struct malloc_zone_t {
__private: [crate::uintptr_t; 18], // FIXME: needs arm64 auth pointers support
__private: [crate::uintptr_t; 18], // FIXME(macos): needs arm64 auth pointers support
}

pub struct ucontext_t {
2 changes: 1 addition & 1 deletion src/unix/bsd/apple/b64/mod.rs
Original file line number Diff line number Diff line change
@@ -77,7 +77,7 @@ cfg_if! {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.debug_struct("pthread_attr_t")
.field("__sig", &self.__sig)
// FIXME: .field("__opaque", &self.__opaque)
// FIXME(debug): .field("__opaque", &self.__opaque)
.finish()
}
}
2 changes: 1 addition & 1 deletion src/unix/bsd/apple/b64/x86_64/mod.rs
Original file line number Diff line number Diff line change
@@ -106,7 +106,7 @@ s! {
}

pub struct malloc_introspection_t {
_private: [crate::uintptr_t; 16], // FIXME: keeping private for now
_private: [crate::uintptr_t; 16], // FIXME(macos): keeping private for now
}

pub struct malloc_zone_t {
30 changes: 15 additions & 15 deletions src/unix/bsd/apple/mod.rs
Original file line number Diff line number Diff line change
@@ -361,7 +361,7 @@ s! {
}

pub struct sigaction {
// FIXME: this field is actually a union
// FIXME(union): this field is actually a union
pub sa_sigaction: crate::sighandler_t,
pub sa_mask: sigset_t,
pub sa_flags: c_int,
@@ -1304,9 +1304,9 @@ s_no_extra_traits! {
pub shm_lpid: crate::pid_t,
pub shm_cpid: crate::pid_t,
pub shm_nattch: crate::shmatt_t,
pub shm_atime: crate::time_t, // FIXME: 64-bit wrong align => wrong offset
pub shm_dtime: crate::time_t, // FIXME: 64-bit wrong align => wrong offset
pub shm_ctime: crate::time_t, // FIXME: 64-bit wrong align => wrong offset
pub shm_atime: crate::time_t, // FIXME(macos): 64-bit wrong align => wrong offset
pub shm_dtime: crate::time_t, // FIXME(macos): 64-bit wrong align => wrong offset
pub shm_ctime: crate::time_t, // FIXME(macos): 64-bit wrong align => wrong offset
// FIXME: 64-bit wrong align => wrong offset:
pub shm_internal: *mut c_void,
}
@@ -1891,7 +1891,7 @@ cfg_if! {
.field("pth_curpri", &self.pth_curpri)
.field("pth_priority", &self.pth_priority)
.field("pth_maxpriority", &self.pth_maxpriority)
// FIXME: .field("pth_name", &self.pth_name)
// FIXME(debug): .field("pth_name", &self.pth_name)
.finish()
}
}
@@ -1957,8 +1957,8 @@ cfg_if! {
.field("f_fssubtype", &self.f_fssubtype)
.field("f_fstypename", &self.f_fstypename)
.field("f_type", &self.f_type)
// FIXME: .field("f_mntonname", &self.f_mntonname)
// FIXME: .field("f_mntfromname", &self.f_mntfromname)
// FIXME(debug): .field("f_mntonname", &self.f_mntonname)
// FIXME(debug): .field("f_mntfromname", &self.f_mntfromname)
.field("f_reserved", &self.f_reserved)
.finish()
}
@@ -2008,7 +2008,7 @@ cfg_if! {
.field("d_reclen", &self.d_reclen)
.field("d_namlen", &self.d_namlen)
.field("d_type", &self.d_type)
// FIXME: .field("d_name", &self.d_name)
// FIXME(debug): .field("d_name", &self.d_name)
.finish()
}
}
@@ -2037,7 +2037,7 @@ cfg_if! {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.debug_struct("pthread_rwlock_t")
.field("__sig", &self.__sig)
// FIXME: .field("__opaque", &self.__opaque)
// FIXME(debug): .field("__opaque", &self.__opaque)
.finish()
}
}
@@ -2065,7 +2065,7 @@ cfg_if! {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.debug_struct("pthread_mutex_t")
.field("__sig", &self.__sig)
// FIXME: .field("__opaque", &self.__opaque)
// FIXME(debug): .field("__opaque", &self.__opaque)
.finish()
}
}
@@ -2094,7 +2094,7 @@ cfg_if! {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.debug_struct("pthread_cond_t")
.field("__sig", &self.__sig)
// FIXME: .field("__opaque", &self.__opaque)
// FIXME(debug): .field("__opaque", &self.__opaque)
.finish()
}
}
@@ -2133,7 +2133,7 @@ cfg_if! {
.field("ss_family", &self.ss_family)
.field("__ss_pad1", &self.__ss_pad1)
.field("__ss_align", &self.__ss_align)
// FIXME: .field("__ss_pad2", &self.__ss_pad2)
// FIXME(debug): .field("__ss_pad2", &self.__ss_pad2)
.finish()
}
}
@@ -2173,13 +2173,13 @@ cfg_if! {
impl fmt::Debug for utmpx {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.debug_struct("utmpx")
// FIXME: .field("ut_user", &self.ut_user)
// FIXME(debug): .field("ut_user", &self.ut_user)
.field("ut_id", &self.ut_id)
.field("ut_line", &self.ut_line)
.field("ut_pid", &self.ut_pid)
.field("ut_type", &self.ut_type)
.field("ut_tv", &self.ut_tv)
// FIXME: .field("ut_host", &self.ut_host)
// FIXME(debug): .field("ut_host", &self.ut_host)
.field("ut_pad", &self.ut_pad)
.finish()
}
@@ -2421,7 +2421,7 @@ cfg_if! {
.field("pth_curpri", &self.pth_curpri)
.field("pth_priority", &self.pth_priority)
.field("pth_maxpriority", &self.pth_maxpriority)
// FIXME: .field("pth_name", &self.pth_name)
// FIXME(debug): .field("pth_name", &self.pth_name)
.finish()
}
}
8 changes: 4 additions & 4 deletions src/unix/bsd/freebsdlike/dragonfly/mod.rs
Original file line number Diff line number Diff line change
@@ -560,7 +560,7 @@ cfg_if! {
.field("ut_name", &self.ut_name)
.field("ut_id", &self.ut_id)
.field("ut_line", &self.ut_line)
// FIXME: .field("ut_host", &self.ut_host)
// FIXME(debug): .field("ut_host", &self.ut_host)
.field("ut_unused", &self.ut_unused)
.field("ut_session", &self.ut_session)
.field("ut_type", &self.ut_type)
@@ -639,7 +639,7 @@ cfg_if! {
.field("d_type", &self.d_type)
// Ignore __unused1
// Ignore __unused2
// FIXME: .field("d_name", &self.d_name)
// FIXME(debug): .field("d_name", &self.d_name)
.finish()
}
}
@@ -701,10 +701,10 @@ cfg_if! {
.field("f_flags", &self.f_flags)
.field("f_syncwrites", &self.f_syncwrites)
.field("f_asyncwrites", &self.f_asyncwrites)
// FIXME: .field("f_mntonname", &self.f_mntonname)
// FIXME(debug): .field("f_mntonname", &self.f_mntonname)
.field("f_syncreads", &self.f_syncreads)
.field("f_asyncreads", &self.f_asyncreads)
// FIXME: .field("f_mntfromname", &self.f_mntfromname)
// FIXME(debug): .field("f_mntfromname", &self.f_mntfromname)
.finish()
}
}
14 changes: 7 additions & 7 deletions src/unix/bsd/freebsdlike/freebsd/mod.rs
Original file line number Diff line number Diff line change
@@ -1660,7 +1660,7 @@ s_no_extra_traits! {
pub kf_flags: c_int,
_kf_pad0: c_int,
pub kf_offset: i64,
_priv: [u8; 304], // FIXME: this is really a giant union
_priv: [u8; 304], // FIXME(freebsd): this is really a giant union
pub kf_status: u16,
_kf_pad1: u16,
_kf_ispare0: c_int,
@@ -1711,8 +1711,8 @@ cfg_if! {
.field("ut_pid", &self.ut_pid)
.field("ut_user", &self.ut_user)
.field("ut_line", &self.ut_line)
// FIXME: .field("ut_host", &self.ut_host)
// FIXME: .field("__ut_spare", &self.__ut_spare)
// FIXME(debug): .field("ut_host", &self.ut_host)
// FIXME(debug): .field("__ut_spare", &self.__ut_spare)
.finish()
}
}
@@ -1799,7 +1799,7 @@ cfg_if! {
.field("sdl_nlen", &self.sdl_nlen)
.field("sdl_alen", &self.sdl_alen)
.field("sdl_slen", &self.sdl_slen)
// FIXME: .field("sdl_data", &self.sdl_data)
// FIXME(debug): .field("sdl_data", &self.sdl_data)
.finish()
}
}
@@ -2291,7 +2291,7 @@ cfg_if! {
f.debug_struct("sctp_gen_error_cause")
.field("code", &{ self.code })
.field("length", &{ self.length })
// FIXME: .field("info", &{self.info})
// FIXME(debug): .field("info", &{self.info})
.finish()
}
}
@@ -2363,7 +2363,7 @@ cfg_if! {
f.debug_struct("sctp_error_missing_param")
.field("cause", &{ self.cause })
.field("num_missing_params", &{ self.num_missing_params })
// FIXME: .field("tpe", &{self.tpe})
// FIXME(debug): .field("tpe", &{self.tpe})
.finish()
}
}
@@ -5664,7 +5664,7 @@ extern "C" {
pub fn pidfile_close(path: *mut crate::pidfh) -> c_int;
pub fn pidfile_remove(path: *mut crate::pidfh) -> c_int;
pub fn pidfile_fileno(path: *const crate::pidfh) -> c_int;
// FIXME: pidfile_signal in due time (both manpage present and updated image snapshot)
// FIXME(freebsd): pidfile_signal in due time (both manpage present and updated image snapshot)
}

#[link(name = "procstat")]
2 changes: 1 addition & 1 deletion src/unix/bsd/freebsdlike/freebsd/x86_64/mod.rs
Original file line number Diff line number Diff line change
@@ -344,7 +344,7 @@ cfg_if! {
.field("mc_len", &self.mc_len)
.field("mc_fpformat", &self.mc_fpformat)
.field("mc_ownedfp", &self.mc_ownedfp)
// FIXME: .field("mc_fpstate", &self.mc_fpstate)
// FIXME(debug): .field("mc_fpstate", &self.mc_fpstate)
.field("mc_fsbase", &self.mc_fsbase)
.field("mc_gsbase", &self.mc_gsbase)
.field("mc_xfpustate", &self.mc_xfpustate)
2 changes: 1 addition & 1 deletion src/unix/bsd/freebsdlike/mod.rs
Original file line number Diff line number Diff line change
@@ -418,7 +418,7 @@ cfg_if! {
.field("ss_family", &self.ss_family)
.field("__ss_pad1", &self.__ss_pad1)
.field("__ss_align", &self.__ss_align)
// FIXME: .field("__ss_pad2", &self.__ss_pad2)
// FIXME(debug): .field("__ss_pad2", &self.__ss_pad2)
.finish()
}
}
21 changes: 11 additions & 10 deletions src/unix/bsd/netbsdlike/netbsd/mod.rs
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@ pub type fsfilcnt_t = u64;
pub type idtype_t = c_int;
pub type mqd_t = c_int;
type __pthread_spin_t = __cpu_simple_lock_nv_t;
pub type vm_size_t = crate::uintptr_t; // FIXME: deprecated since long time
pub type vm_size_t = crate::uintptr_t; // FIXME(deprecated): deprecated since long time
pub type lwpid_t = c_uint;
pub type shmatt_t = c_uint;
pub type cpuid_t = c_ulong;
@@ -297,7 +297,8 @@ s! {
pub flags: u32,
pub fflags: u32,
pub data: i64,
pub udata: intptr_t, /* FIXME: NetBSD 10.0 will finally have same layout as other BSD */
// FIXME(netbsd): NetBSD 10.0 will finally have same layout as other BSD
pub udata: intptr_t,
}

pub struct dqblk {
@@ -799,7 +800,7 @@ s_no_extra_traits! {
pub ut_session: u16,
pub ut_type: u16,
pub ut_pid: crate::pid_t,
pub ut_exit: __exit_status, // FIXME: when anonymous struct are supported
pub ut_exit: __exit_status, // FIXME(netbsd): when anonymous struct are supported
pub ut_ss: sockaddr_storage,
pub ut_tv: crate::timeval,
pub ut_pad: [u8; _UTX_PADSIZE],
@@ -945,14 +946,14 @@ cfg_if! {
.field("ut_name", &self.ut_name)
.field("ut_id", &self.ut_id)
.field("ut_line", &self.ut_line)
// FIXME .field("ut_host", &self.ut_host)
// FIXME(debug) .field("ut_host", &self.ut_host)
.field("ut_session", &self.ut_session)
.field("ut_type", &self.ut_type)
.field("ut_pid", &self.ut_pid)
.field("ut_exit", &self.ut_exit)
.field("ut_ss", &self.ut_ss)
.field("ut_tv", &self.ut_tv)
// FIXME .field("ut_pad", &self.ut_pad)
// FIXME(debug) .field("ut_pad", &self.ut_pad)
.finish()
}
}
@@ -993,7 +994,7 @@ cfg_if! {
f.debug_struct("lastlogx")
.field("ll_tv", &self.ll_tv)
.field("ll_line", &self.ll_line)
// FIXME.field("ll_host", &self.ll_host)
// FIXME(debug).field("ll_host", &self.ll_host)
.field("ll_ss", &self.ll_ss)
.finish()
}
@@ -1159,7 +1160,7 @@ cfg_if! {
.field("d_reclen", &self.d_reclen)
.field("d_namlen", &self.d_namlen)
.field("d_type", &self.d_type)
// FIXME: .field("d_name", &self.d_name)
// FIXME(debug): .field("d_name", &self.d_name)
.finish()
}
}
@@ -1235,8 +1236,8 @@ cfg_if! {
.field("f_owner", &self.f_owner)
.field("f_spare", &self.f_spare)
.field("f_fstypename", &self.f_fstypename)
// FIXME: .field("f_mntonname", &self.f_mntonname)
// FIXME: .field("f_mntfromname", &self.f_mntfromname)
// FIXME(debug): .field("f_mntonname", &self.f_mntonname)
// FIXME(debug): .field("f_mntfromname", &self.f_mntfromname)
.finish()
}
}
@@ -1290,7 +1291,7 @@ cfg_if! {
.field("ss_family", &self.ss_family)
.field("__ss_pad1", &self.__ss_pad1)
.field("__ss_pad2", &self.__ss_pad2)
// FIXME: .field("__ss_pad3", &self.__ss_pad3)
// FIXME(debug): .field("__ss_pad3", &self.__ss_pad3)
.finish()
}
}