freebsd add basic ethernet frames support #4252
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
fbsd_ethernet
branch
from
2fd85cc to
b5ff627
Compare
asomers
reviewed
Jan 27, 2025
| @@ -2541,6 +2553,55 @@ cfg_if! { | |||
| .finish() | |||
| } | |||
| } | |||
|
|
|||
| // FIXME(msrv): `derive` on packed structs cannot be used below 1.67 | |||
There was a problem hiding this comment.
That sounds to me like a compelling reason to raise the main branch's MSRV. Why is it currently set to 1.63?
There was a problem hiding this comment.
1.63 is what Debian stable currently ships so it is a pretty common baseline in the ecosystem. In a few months Trixie will be released 1.83 (or higher) so we will probably be able to do another bump (not that high, but at least above 1.63).
| @@ -4957,6 +5028,24 @@ f! { | |||
| pub fn PROT_MAX_EXTRACT(x: c_int) -> c_int { | |||
| (x >> 16) & (crate::PROT_READ | crate::PROT_WRITE | crate::PROT_EXEC) | |||
| } | |||
|
|
|||
| pub {const} fn ETHER_IS_MULTICAST(addr: *mut u_char) -> bool { | |||
| (*addr.wrapping_add(0)) & 0x01 != 0x00 | |||
There was a problem hiding this comment.
I'm surprised that Clippy doesn't complain about the uselessness of wrapping_add(0).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reference