internal: Build source map for hir_def::TypeRefs
#18074
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #18075) made this pull request unmergeable. Please resolve the merge conflicts. |
ChayimFriedman2
force-pushed
the
typeref-source-map
branch
from
fdd56f9
to
9af921a
Compare
So that given a `TypeRef` we will be able to trace it back to source code. This is necessary to be able to provide diagnostics for lowering to chalk tys, since the input to that is `TypeRef`. This means that `TypeRef`s now have an identity, which means storing them in arena and not interning them, which is an unfortunate (but necessary) loss but also a pretty massive change. Luckily, because of the separation layer we have for IDE and HIR, this change never crosses the IDE boundary.
ChayimFriedman2
force-pushed
the
typeref-source-map
branch
from
9af921a
to
3c34665
Compare
|
Okay, this is ready for review. I intend to submit a follow-up PR with few cleanups that I don't want to insert here to not increase the size of this already-large PR. |
ChayimFriedman2
changed the title
hir_def::TypeRefshir_def::TypeRefs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that given a
TypeRefwe will be able to trace it back to source code.This is necessary to be able to provide diagnostics for lowering to chalk tys, since the input to that is
TypeRef. This is the first step towards diagnostics for ty lowering. The next steps will be smaller :PThis means that
TypeRefs now have an identity, which means storing them in arena and not interning them, which is an unfortunate (but necessary) loss but also a pretty massive change. Luckily, because of the separation layer we have for IDE and HIR, this change never crosses the IDE boundary.This gives an unfortunate regression of ~170mb in
analysis-stats ..Sorry for the size of the PR; I did some extra things but they are trivial - most of the code is necessary and impossible to split.