fix: Correctly escape strings in our quote macro #18092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
changed the title
ChayimFriedman2
force-pushed
the
fix-stringify
branch
2 times, most recently
from
39a0532
to
019472b
Compare
This is a small change, but it was the cause of 90% of the errors in `rust-analyzer diagnostics .` 🫢 With this change and rust-lang#18085 together, all remaining errors are type errors. This may mean we can enable more errors, but this is out of scope for this PR.
ChayimFriedman2
force-pushed
the
fix-stringify
branch
from
019472b
to
7c44d45
Compare
lnicola
approved these changes
Sep 10, 2024
|
@bors delegate+ |
|
✌️ @ChayimFriedman2, you can now approve this pull request! If @lnicola told you to " |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change, but it was the cause of 90% of the errors in
rust-analyzer diagnostics .🫢 (because this worked incorrectly withstringify!(), which means everyquote!()(the original one) quoting a string also didn't work).With this change and #18085 together, all remaining errors are type errors.
This may mean we can enable more errors, but this is out of scope for this PR.