fix: Handle lint attributes that are under #[cfg_attr]
#18108
+120
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
force-pushed
the
lint-level-cfg
branch
from
434e835
to
135fdda
Compare
|
☔ The latest upstream changes (presumably #18128) made this pull request unmergeable. Please resolve the merge conflicts. |
ChayimFriedman2
force-pushed
the
lint-level-cfg
branch
from
135fdda
to
41ad1a5
Compare
|
☔ The latest upstream changes (presumably #18131) made this pull request unmergeable. Please resolve the merge conflicts. |
ChayimFriedman2
force-pushed
the
lint-level-cfg
branch
from
41ad1a5
to
14701b5
Compare
|
☔ The latest upstream changes (presumably #18146) made this pull request unmergeable. Please resolve the merge conflicts. |
ChayimFriedman2
force-pushed
the
lint-level-cfg
branch
from
14701b5
to
82124f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot
cfg_attrwhile working on #18099. Although the original code also didn't handle that (although case lints specifically were correct, by virtue of using hir attrs).