-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change uninlined_format_args into a style lint #9600
Conversation
r? @Alexendoo (rust-highfive has picked a reviewer for you, use r? to override) |
Taking over review from @Alexendoo to reduce his load. I'd like to see an r? @llogiq |
@llogiq take a look at #9605 -- I tried to add a 2018 edition, and fix the bug with the panic, but somehow the test does not run as 2018th edition - could you see if i need to do something else there to fix it? Thanks! |
Ok, so I'll try getting #9605 merged first. |
This one is ready to go |
@bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
As previously discussed, the
uninlined_format_args
should probably be a part of the default style becauseprintln!("{}", foo)
is not as concise or easy to understand asprintln!("{foo}")
changelog: [
uninlined_format_args
]: change to be the defaultstyle