-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for wasm32-wali-linux-musl
Tier-3 target
#135651
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @chenyukang (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
|
This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. These commits modify compiler targets. |
wasm32-wali-linux-musl
targetwasm32-wali-linux-musl
Tier-3 target
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend you disable the std support that depends on libc/stdarch, rather than requiring diffs to them to land first.
Realized I pulled in all cyclic dependency required changes to get the build to work locally. I'll split the PRs as mentioned without libc/stdarch so PRs can land |
…e Wasm Linux Interface This commit does not patch libc, stdarch, or cc
These commits modify compiler targets. This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. |
Adding a new target --
wasm32-wali-linux-musl
-- to the compiler can target the WebAssembly Linux Interface according to MCP rust-lang/compiler-team#797Preliminary support involves minimal changes, primarily
wasm32_wali_linux_musl
that bridges linux options with supported wasm options. Right now, since there is no canonical Linux ABI for Wasm, we usewali
in the vendor field, but this can be migrated in future version.wasm32-wali-linux-musl
Tier-3 Linux target stdarch#1702wasm32-wali
libc#4244wasm32-wali-linux-musl
Tier-3 Linux target cc-rs#1373cc @tgross35 for libc-related changes
Tier-3 policy:
I will take responsibility for maintaining this target as well as issues
The target name is consistent with naming patterns from currently supported targets for arch (wasm32), OS, (linux) and env (musl)
No naming confusion is introduced.
Compliant
It's fully open source
Noted
Compliant
All tools are open-source
No terms present
I am not a reviewer
This target supports the full standard library with appropriate configuration stubs where necessary (however, similar to all existing wasm32 targets, it excludes dynamic linking or hardware-specific features)
Preliminary documentation is provided at https://github.com/arjunr2/WALI. Further detailed docs (if necessary) can be added once this PR lands
Understood
To the best of my knowledge, it does not break any existing target in the ecosystem -- only minimal configuration-specific additions were made to support the target.
We can upstream LLVM target support