Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify publishing workflows #5911

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andrewpollack
Copy link
Member

@andrewpollack andrewpollack commented Sep 11, 2024

  • Shift to three primary 'make' recipes:
    * make website: Generates and locally hosts website content, echoing the latest entry for easy access
    * make copy-website-contents: Takes above generated website, and syncs state with the input directory
    * make email: Generates website content formatted for email, then uses 'juice' for creating optimized format. Lands final email in new directory, and echos the location
  • Separate output directories to "output-website/" and "output-email-format/" to avoid potential confusion
  • Bump node version 16 -> 20

Notably, email generation no longer requires bringing up two windows, nor does it require updating a variable to fetch latest. All is handled automatically

* Shift to three primary 'make' recipes:
  * 'make website': Generates and locally hosts website content, echoing the latest entry for easy access
  * 'make copy-website-contents: Takes above generated website, and syncs state with the input directory
  * 'make email': Generates website content formatted for email, then uses 'juice' for creating optimized format. Lands final email in new  directory, and echos the location
* Separate output directories to "output-website/" and "output-email-format/" to avoid potential confusion

Notably, email generation no longer requires bringing up two windows, nor does it require updating the  variable. All is handled automatically
@andrewpollack
Copy link
Member Author

image

Output of make website will print out a suggestion to run make copy-website-contents to help in the syncing step

@andrewpollack
Copy link
Member Author

I'll need to update the weekly release process docs if this seems like a solid flow, but I'm curious if @mariannegoldin can give this a shot to validate on the next publishing cycle 🙏

@mariannegoldin
Copy link
Contributor

Going to keep this one open for a bit for editors' review.

Copy link
Contributor

@nellshamrell nellshamrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic! Ty, @andrewpollack!

Copy link
Contributor

@bennyvasquez bennyvasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks incredible, @andrewpollack! I wonder if we should wait to merge it until a week where we know you'll be around so we can work with you on any problems that might come up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants