Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the generated JS shim calls
TextDe/Encoder
, even if it's not required by the user.This forces users to provide a polyfill even when not needed.
Even if just a stub is provided as a polyfill, like done in the
wasm-audio-worklet
example, it would still require the classTextDe/Encoder
to be defined, which prevents support detection by downstream users.This adjust calls to
TextDe/Encoder
to do nothing if it's not available.I don't think this has any use-case outside audio worklets.
This doesn't prevent users from using an actual polyfill if desired.
Cc @lukaslihotzki.
Fixes #2367.