feat: return withdrawn amount and protocol fee #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: DRY'ify Vars struct
PaulRBerg
reviewed
Oct 14, 2024
PaulRBerg
reviewed
Oct 14, 2024
refactor: explicitness with protocolFeeAmount Co-authored-by: Paul Razvan Berg <[email protected]>
smol-ninja
force-pushed
the
feat/return-withdraw
branch
3 times, most recently
from
00ca306
to
231c76a
Compare
PaulRBerg
changed the title
amountWithdrawn and feeTaken in withdraw
docs: polish natspecs for withdraw and withdrawMax Co-authored-by: Andrei Vlad Birgaoanu <[email protected]>
andreivladbrg
approved these changes
Oct 14, 2024
smol-ninja
force-pushed
the
feat/return-withdraw
branch
from
4776e20
to
2087e0f
Compare
andreivladbrg
added a commit
that referenced
this pull request
Oct 15, 2024
* feat: return amountWithdrawn and feeTaken in withdraw test: DRY'ify Vars struct * refactor: follow somethingSomethingAmount pattern for variables naming refactor: explicitness with protocolFeeAmount Co-authored-by: Paul Razvan Berg <[email protected]> * test: declare vars in Base contract docs: polish natspecs for withdraw and withdrawMax Co-authored-by: Andrei Vlad Birgaoanu <[email protected]> * merge conflict --------- Co-authored-by: Paul Razvan Berg <[email protected]> Co-authored-by: Andrei Vlad Birgaoanu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Varsstruct #275#275 is a pre-requisite to achieve #301 in order to avoid stack too deep errors in tests.