Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: revert depletionTimeOf if balance is zero #335

Merged
merged 2 commits into from
Nov 13, 2024
Merged

feat: revert depletionTimeOf if balance is zero #335

merged 2 commits into from
Nov 13, 2024

Conversation

smol-ninja
Copy link
Member

@smol-ninja smol-ninja commented Nov 11, 2024 •
edited
Loading

Closes #332

@andreivladbrg

This comment was marked as outdated.

Sign in to view
@smol-ninja

This comment was marked as outdated.

Sign in to view
andreivladbrg
andreivladbrg approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@andreivladbrg andreivladbrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r_downey_thumbs_up

src/interfaces/ISablierFlow.sol Show resolved Hide resolved
@smol-ninja smol-ninja merged commit 8348fe5 into main Nov 13, 2024
7 checks passed
@smol-ninja
Copy link
Member Author

I'll include the unchecked task in #334

@smol-ninja smol-ninja deleted the finding/codehawk-03 branch November 13, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreivladbrg andreivladbrg andreivladbrg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revert depletionTimeOf if balance == 0
2 participants
@smol-ninja @andreivladbrg